Better error reporting for download failures.

peeyush113 · Feb 10, 2010 · fc34997 · fc34997
1 parent 7e4b1d5
commit fc34997
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,4 @@ release
 temp
 etc/intellij/*.iws
 */build
+.DS_Store
diff --git a/core/src/java/main/org/uncommons/zeitgeist/FeedDownloadTask.java b/core/src/java/main/org/uncommons/zeitgeist/FeedDownloadTask.java
@@ -20,6 +20,7 @@
 import com.sun.syndication.feed.synd.SyndEntry;
 import com.sun.syndication.feed.synd.SyndFeed;
 import com.sun.syndication.fetcher.FeedFetcher;
+import com.sun.syndication.fetcher.FetcherException;
 import com.sun.syndication.fetcher.impl.HashMapFeedInfoCache;
 import com.sun.syndication.fetcher.impl.HttpURLFeedFetcher;
 import java.net.MalformedURLException;
@@ -88,6 +89,10 @@ public List<Article> call() throws Exception
             }
             return feedArticles;
         }
+        catch (FetcherException ex)
+        {
+            LOG.error("Failed fetching " + feedURL + ", " + ex.getMessage());
+        }
         catch (UnknownHostException ex)
         {
             LOG.error("Failed fetching " + feedURL + ", unknown host.");

diff --git a/core/src/java/main/org/uncommons/zeitgeist/Zeitgeist.java b/core/src/java/main/org/uncommons/zeitgeist/Zeitgeist.java
@@ -147,7 +147,7 @@ private List<Article> downloadArticles()
                 catch (ExecutionException ex)
                 {
                     // Log the failure for this feed, but carry on with other feeds.
-                    ex.printStackTrace();
+                    LOG.errorException(ex.getCause());
                 }
             }
             executor.shutdown();
@@ -214,7 +214,10 @@ private List<Topic> extractTopics(List<Article> articles,
             else
             {
                 String detail = topicArticles.isEmpty() ? "???" : topicArticles.get(0).getItem().getHeadline();
-                LOG.verbose(String.format("Discarding topic \"%s\" (%d), too few sources (%d)", detail, topicArticles.size(), sources));
+                LOG.verbose(String.format("Discarding topic \"%s\" (%d), too few sources (%d)",
+                                          detail,
+                                          topicArticles.size(),
+                                          sources));
             }
         }
 

diff --git a/feedlists/football.txt b/feedlists/football.txt
@@ -18,7 +18,7 @@ http://www.goal.com/en/feeds/news?fmt=rss
 http://www.thesun.co.uk/sol/homepage/feeds/rss/article247739.ece
 http://feeds.teletext.co.uk/sport/football/stories
 http://www.newsoftheworld.co.uk/feeds/rss/article186490.ece
-http://www.uefa.com/rssfeed/footballeurope/index.xml
+http://www.uefa.com/rssfeed/news/rss.xml
 http://resources.sportingo.com/Sportingo_RSS/Section/Football.xml
 http://www.express.co.uk/posts/rss/67/football
 http://www.metro.co.uk/xml/rss/page.xml?in_page_id=43