Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: set ContentType for uploaded files #84

Merged
merged 4 commits into from
Mar 6, 2020
Merged

core: set ContentType for uploaded files #84

merged 4 commits into from
Mar 6, 2020

Conversation

igungor
Copy link
Member

@igungor igungor commented Mar 2, 2020 •
edited
Loading

Fixes #33

@igungor
core: set ContentType for uploaded files
bcb969e 
WIP - DO NOT MERGE: needs tests

Fixes #33
@igungor igungor requested a review from sonmezonur March 2, 2020 17:02
@igungor
Copy link
Member Author

igungor commented Mar 3, 2020

@sonmezonur please review

@igungor
Copy link
Member Author

igungor commented Mar 3, 2020

I'm going to wait for #87

@igungor igungor merged commit e074b96 into master Mar 6, 2020
@igungor igungor deleted the content-type branch March 6, 2020 11:59
@igungor igungor added this to the v1.0.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonmezonur sonmezonur sonmezonur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Upload to S3 always adds metadata "content-type: binary/octet-stream" instead of default per filetype.
2 participants
@igungor @sonmezonur