command: update misleading help descriptions #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizsurmeli
requested review from
igungor and
seruman
and removed request for
a team
sonmezonur
approved these changes
Jul 6, 2023
|
@denizsurmeli congrats on your first PR! We try to use |
seruman
approved these changes
Jul 7, 2023
seruman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the help messages for the commands that takes arguments containing wildcards. Since the expansion of wildcards are evaluated by the shell and not by the
s5cmdbeforehand, there is no way for app to prevent the expansion. We urge users to consider escaping from globbing by wrapping the related argument to quotes. Obviously, the escaping method can be different for every shell implementation.Fixes #555