Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return structured type after running each job #56

Merged
merged 15 commits into from
Feb 18, 2020
Merged

Return structured type after running each job #56

merged 15 commits into from
Feb 18, 2020

Conversation

sonmezonur
Copy link
Member

  • Remove AcceptableError
  • Return JobResponse after each command
  • Remove numFails, numSuccess and numAcceptableFails from Job
  • Implement generic Log() function
  • Do not print stats on parent job

igungor
igungor reviewed Feb 17, 2020
View reviewed changes
core/op_s3.go Outdated Show resolved Hide resolved
igungor
igungor reviewed Feb 17, 2020
View reviewed changes
e2e/bang_test.go Outdated Show resolved Hide resolved
igungor
igungor reviewed Feb 18, 2020
View reviewed changes
core/jobargument.go Outdated Show resolved Hide resolved
igungor
igungor reviewed Feb 18, 2020
View reviewed changes
core/jobargument.go Outdated Show resolved Hide resolved
@igungor igungor merged commit 3602059 into master Feb 18, 2020
@igungor igungor deleted the job-status branch February 18, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor approved these changes

@ilkinulas ilkinulas Awaiting requested review from ilkinulas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonmezonur @igungor