Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: add dockerfile #223

Merged
merged 7 commits into from
Aug 31, 2020
Merged

dockerfile: add dockerfile #223

merged 7 commits into from
Aug 31, 2020

Conversation

fbarotov
Copy link
Contributor

Resolves #219

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ilkinulas
Copy link
Member

@fbarotov could you please add a new section to README which shows how to build and run s5cmd docker image.

  • docker build ...
  • docker run ( --env-file flag from credentials)

We will update it after we publish the image to a public repo.

@fbarotov
Copy link
Contributor Author

@fbarotov could you please add a new section to README which shows how to build and run s5cmd docker image.

  • docker build ...
  • docker run ( --env-file flag from credentials)

We will update it after we publish the image to a public repo.

thanks for the help and suggestion. done.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@igungor igungor changed the title dockerfile: added dockerfile dockerfile: add dockerfile Aug 31, 2020
@igungor
Copy link
Member

igungor commented Aug 31, 2020

@aykutfarsak could you re-review please?

Copy link
Contributor

@aykutfarsak aykutfarsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@igungor igungor merged commit b037325 into peak:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Dockerfile
5 participants