Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop local->local copy support #118

Closed
igungor opened this issue Mar 24, 2020 · 0 comments · Fixed by #125
Closed

Drop local->local copy support #118

igungor opened this issue Mar 24, 2020 · 0 comments · Fixed by #125
Assignees
@igungor
Milestone
v1.0.0

Comments

@igungor
Copy link
Member

igungor commented Mar 24, 2020

s5cmd supports local to local copy/move operations. I'm not sure we have a strong use-case to support it.

Also we have the -R recursive parameter which is used only for local->local copy. Seeing this parameter in the copy help output confuses me whether I need to use it to upload a directory to S3 or not.

I think we should drop -R and local->local copy support entirely if there's no opposition.
@igungor igungor added this to the v1.0.0 milestone Mar 24, 2020
@igungor igungor self-assigned this Mar 25, 2020
igungor added a commit that referenced this issue Mar 25, 2020
@igungor
command/copy: drop local->local copy support
9ba99f7 
Fixes #118
@igungor igungor mentioned this issue Mar 25, 2020
Merged
igungor added a commit that referenced this issue Mar 26, 2020
@igungor
command/copy: drop local->local copy support (#125)
2079136 
Fixes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igungor igungor

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

command/copy: drop local->local copy support peak/s5cmd
1 participant
@igungor