fix: Bug with silent fail and aarch64 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltickett
changed the title
ltickett
changed the title
In Debian `get_arch` returns `aarch64` which then causes a failure. Unfortunately, because the failure happens during an assignment it isn't surfaced to stderr. This PR adds a mapping for `aarch64` -> `arm64` and fixes the silent fail but forcing the output to `/dev/stderr`.
ltickett
force-pushed
the
fix-arm64-and-fail-bugs
branch
from
c5bbc5c
to
c3cf283
Compare
|
@pdemagny could you take a look at these couple of bug fixes please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Debian
get_archreturnsaarch64which then causes a failure.Unfortunately, because the failure happens during an assignment it isn't surfaced to stderr.
This PR adds a mapping for
aarch64->arm64and fixes the silent fail but forcing the output to/dev/stderr.Thanks to Stan Hu @ GitLab for troubleshooting and supplying the fix 🙏