introduce a built-in default implementation for a connect-middleware #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets not ask everybody to copy-paste this middleware. lets user-code customise the augmented attribute name
|
if you decide to merge it - it would be nice if you could tell us when it's published, so we can bump the dependency version and use the built-in m/w :) |
|
@osherx this is great, I definitely like the middleware implementation and will merge it. I'll take a look and let you know when I bump the version. |
pbojinov
added a commit
that referenced
this pull request
Jan 27, 2016
introduce a built-in default implementation for a connect-middleware
|
@osherx sorry for the delay, it's good to go. Thank you for you help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets not ask everybody to copy-paste this middleware code...
lets use a factory pattern to let users customise the middleware (and as a container for any future settings we may think to feature