lkdtm: fix memory leak of base

This case is supposed to read from a memory after it has been freed, but we missed freeing base if the memory 'val' could not be allocated. Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Kees Cook <[email protected]>
patjak · Apr 6, 2016 · d2e1008 · d2e1008
1 parent 50fbd97
commit d2e1008
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
@@ -458,8 +458,10 @@ static void lkdtm_do_action(enum ctype which)
 			break;
 
 		val = kmalloc(len, GFP_KERNEL);
-		if (!val)
+		if (!val) {
+			kfree(base);
 			break;
+		}
 
 		*val = 0x12345678;
 		base[offset] = *val;