Skip to content

Commit

Permalink
virtio: console: rename variable
Browse files Browse the repository at this point in the history
'ret' is a misnomer in discard_port_data() since we don't return the
value.  Rename it to 'err'.
Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
Amit Shah authored and rustyrussell committed Nov 2, 2011
1 parent d25a9dd commit ce072a0
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/char/virtio_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,7 @@ static void discard_port_data(struct port *port)
{
struct port_buffer *buf;
struct virtqueue *vq;
unsigned int len;
int ret;
unsigned int len, err;

if (!port->portdev) {
/* Device has been unplugged. vqs are already gone. */
Expand All @@ -400,18 +399,18 @@ static void discard_port_data(struct port *port)
else
buf = virtqueue_get_buf(vq, &len);

ret = 0;
err = 0;
while (buf) {
if (add_inbuf(vq, buf) < 0) {
ret++;
err++;
free_buf(buf);
}
buf = virtqueue_get_buf(vq, &len);
}
port->inbuf = NULL;
if (ret)
if (err)
dev_warn(port->dev, "Errors adding %d buffers back to vq\n",
ret);
err);
}

static bool port_has_data(struct port *port)
Expand Down

0 comments on commit ce072a0

Please sign in to comment.