Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more beacon API types #5292

Merged
merged 5 commits into from
Nov 6, 2023
Merged

feat: add more beacon API types #5292

merged 5 commits into from
Nov 6, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 4, 2023

adds relay api types

adds a lot of glue code to support beacon API serialization, this allows us to reuse the same executionpayload types for beacon API

if this turns out to be bad DX, we can just duplicate them..., we definitely need an additional builder type

also moves some stuff around

@mattsse mattsse requested a review from Rjected as a code owner November 4, 2023 13:48
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Nov 4, 2023
@mattsse mattsse requested review from rkrasiuk and Rjected and removed request for Rjected November 4, 2023 13:49
@mattsse mattsse requested a review from gakonst as a code owner November 4, 2023 13:51
@mattsse mattsse force-pushed the matt/beacon-glue branch 3 times, most recently from e33fae8 to c75f248 Compare November 4, 2023 13:56
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 29a8489 Nov 6, 2023
25 checks passed
@mattsse mattsse deleted the matt/beacon-glue branch November 6, 2023 13:30
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants