Skip to content

Commit

Permalink
Checking in Brett Cannon's patch #662053, which fixes bug #661354.
Browse files Browse the repository at this point in the history
_strptime can now handle getting two empty strings as the timezone information.
  • Loading branch information
jackjansen committed Jan 15, 2003
1 parent 791f7d4 commit 62fe755
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions Lib/_strptime.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,13 +258,12 @@ def __calc_date_time(self):
('17', '%d'), ('03', '%m'), ('3', '%m'),
# '3' needed for when no leading zero.
('2', '%w'), ('10', '%I')):
try:
# Done this way to deal with possible lack of locale info
# manifesting itself as the empty string (i.e., Swedish's
# lack of AM/PM info).
# Must deal with possible lack of locale info
# manifesting itself as the empty string (e.g., Swedish's
# lack of AM/PM info) or a platform returning a tuple of empty
# strings (e.g., MacOS 9 having timezone as ('','')).
if old:
current_format = current_format.replace(old, new)
except ValueError:
pass
time_tuple = time.struct_time((1999,1,3,1,1,1,6,3,0))
if time.strftime(directive, time_tuple).find('00'):
U_W = '%U'
Expand Down Expand Up @@ -351,7 +350,7 @@ def __getitem__(self, fetch):
raise

def __seqToRE(self, to_convert, directive):
"""Convert a list to a regex string for matching directive."""
"""Convert a list to a regex string for matching a directive."""
def sorter(a, b):
"""Sort based on length.
Expand All @@ -370,6 +369,11 @@ def sorter(a, b):
return cmp(b_length, a_length)

to_convert = to_convert[:] # Don't want to change value in-place.
for value in to_convert:
if value != '':
break
else:
return ''
to_convert.sort(sorter)
regex = '|'.join(to_convert)
regex = '(?P<%s>%s' % (directive, regex)
Expand Down Expand Up @@ -473,7 +477,7 @@ def strptime(data_string, format="%a %b %d %H:%M:%S %Y"):
found_zone = found_dict['Z'].lower()
if locale_time.timezone[0] == locale_time.timezone[1]:
pass #Deals with bad locale setup where timezone info is
# the same; first found on FreeBSD 4.4 -current
# the same; first found on FreeBSD 4.4.
elif locale_time.timezone[0].lower() == found_zone:
tz = 0
elif locale_time.timezone[1].lower() == found_zone:
Expand Down

0 comments on commit 62fe755

Please sign in to comment.