Support for service accounts as organization members #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-tranchard
approved these changes
Jul 15, 2024
pnzrr
requested changes
Jul 16, 2024
pnzrr
reviewed
Jul 16, 2024
|
@kedare only one comment, switch out of draft state when you feel it's ready. |
|
Should we add a checkbox to be able to list the service accounts to be able to add/remove them as organization members ? Maybe something to do in another PR (I don't really have the React skills to do that but I guess it should be easy for someone that knows React?) |
|
@kedare something we can consider, can you add it as a ticket to the https://github.com/p2-inc/keycloak-orgs/ repo? |
pnzrr
approved these changes
Jul 16, 2024
|
Will wait to merge until p2-inc/keycloak-orgs#244 is complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add supports to service accounts are organization members
Related to p2-inc/keycloak-orgs#244
I may need some help as I am not really familiar with React, I guess we could add a checkbox on the modal to allow to show or not the service accounts, could you help me with that @xgp ?