-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDPMS-2257 Allow intents to modify external files on lib #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, but it can be merged if it's urgent. Otherwise, it would be good to make these adjustments.
@@ -1,10 +1,22 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<manifest package="com.xinlan.imageeditandroid" | |||
<manifest xmlns:tools="http://schemas.android.com/tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if that’s needed?
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" | ||
android:maxSdkVersion="32" /> | ||
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" | ||
android:maxSdkVersion="32" /> | ||
<uses-permission | ||
android:name="android.permission.READ_MEDIA_AUDIO" | ||
android:minSdkVersion="33" /> | ||
<uses-permission | ||
android:name="android.permission.READ_MEDIA_IMAGES" | ||
android:minSdkVersion="33" /> | ||
<uses-permission | ||
android:name="android.permission.READ_MEDIA_VIDEO" | ||
android:minSdkVersion="33" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice!
int id = v.getId(); | ||
if (id == R.id.take_photo) { | ||
takePhotoClick(); | ||
} else if (id == R.id.edit_image) { | ||
editImageClick(); | ||
} else if (id == R.id.select_ablum) { | ||
selectFromAblum(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same thing as before?
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | ||
albumUpdate(this, saveFilePath); | ||
} else { | ||
FileUtil.albumUpdate(this, saveFilePath); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both having the same name makes it really hard to understand the difference
Description ✍️
This PR does the following:
Evidences 📱
aaa.mp4