Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old future with waker #34

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Remove old future with waker #34

merged 7 commits into from
Jul 20, 2022

Conversation

owent
Copy link
Owner

@owent owent commented Jul 16, 2022

Signed-off-by: WenTao Ou [email protected]

@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2022

This pull request fixes 1 alert when merging 5906f03 into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #34 (dd4ed46) into v2 (b2e6cba) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v2      #34      +/-   ##
==========================================
+ Coverage   87.29%   87.66%   +0.36%     
==========================================
  Files          26       25       -1     
  Lines        1417     1321      -96     
==========================================
- Hits         1237     1158      -79     
+ Misses        180      163      -17     
Impacted Files Coverage Δ
include/libcopp/future/future.h 100.00% <ø> (+2.94%) ⬆️
include/libcopp/future/poller.h 100.00% <0.00%> (ø)
include/libcopp/future/storage.h 90.26% <0.00%> (+10.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e6cba...dd4ed46. Read the comment docs.

Signed-off-by: WenTao Ou <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2022

This pull request fixes 1 alert when merging d90ba82 into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

Signed-off-by: WenTao Ou <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 17, 2022

This pull request fixes 1 alert when merging ce1001b into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2022

This pull request fixes 1 alert when merging 611ebf1 into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2022

This pull request fixes 1 alert when merging 18d8856 into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2022

This pull request fixes 1 alert when merging dd4ed46 into b2e6cba - view on LGTM.com

fixed alerts:

  • 1 for FIXME comment

@owent owent merged commit 3ed780b into v2 Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants