Fixes #14014 #14023
Merged
Fixes #14014 #14023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit f8f2924 has 10 failures in test/js/node/watch/fs.watch.test.ts - 1 failing on 🍎 14 x64test/js/node/test/parallel/fs-watch-recursive-add-file.test.js - 1 failing on 🍎 14 x64test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 x64test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64test/js/node/test/parallel/fs-watch-recursive-add-folder.test.js - 1 failing on 🍎 14 aarch64test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baselinetest/cli/hot/hot.test.ts - 1 failing on 🪟 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baselinetest/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/cli/watch/watch.test.ts - 2 failing on 🪟 x64test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baselinetest/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 13 aarch64 |
dylan-conway
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14014 on macOS
I'm still not sure about Linux but let's see
To test this PR once it builds:
How did you verify your code works?