SAK-47454 Group manager: Inactive users are shown

ottenhoff · Jun 15, 2022 · 5153107 · 5153107
1 parent b527eca
commit 5153107
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...group-manager/src/main/java/org/sakaiproject/groupmanager/controller/GroupController.java b/...group-manager/src/main/java/org/sakaiproject/groupmanager/controller/GroupController.java
@@ -185,9 +185,9 @@ public String showGroup(Model model,
             }
         }
 
-        // For every member of the site or the filtered group, add it to the selector except if they were provided by a role.
+        // For every active member of the site or the filtered group, add it to the selector except if they were provided by a role.
         for (Member member : filterGroup == null ? site.getMembers() : filterGroup.getMembers()) {
-            if (!roleProviderList.contains(member.getRole().getId()) && sectionProvidedUsers.stream().noneMatch(m -> m.getUserId().equals(member.getUserId()))) {
+            if (!roleProviderList.contains(member.getRole().getId()) && sectionProvidedUsers.stream().noneMatch(m -> m.getUserId().equals(member.getUserId())) && member.isActive()) {
                 Optional<User> memberUserOptional = sakaiService.getUser(member.getUserId());
                 if (memberUserOptional.isPresent()) {
                     siteMemberSet.add(memberUserOptional.get());