Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matplotlib dependency #304

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Remove matplotlib dependency #304

merged 1 commit into from
Feb 20, 2023

Conversation

michalk8
Copy link
Collaborator

closes #292

@michalk8 michalk8 added the misc label Feb 17, 2023
@michalk8 michalk8 self-assigned this Feb 17, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@michalk8
Copy link
Collaborator Author

michalk8 commented Feb 17, 2023 •
edited
Loading

Seems like jax==0.4.4 broke the inner jit we use when calling solvers.

marcocuturi
marcocuturi approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

still not a fan of having plotting functionalities in potentials.py...

@michalk8 michalk8 merged commit c465cf1 into ott-jax:main Feb 20, 2023
@bamos bamos mentioned this pull request Feb 22, 2023
Merged
michalk8 added a commit that referenced this pull request Jun 27, 2024
@michalk8
Remove matplotlib dependency (#304)
4ce187e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocuturi marcocuturi marcocuturi approved these changes

Assignees

@michalk8 michalk8

Labels
misc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potentially make matplotlib an optional dependency
2 participants
@michalk8 @marcocuturi