Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU test runner #242

Merged
merged 27 commits into from
Feb 8, 2023
Merged

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Feb 3, 2023

Also add extra pre-commits for the docs.

@michalk8 michalk8 added the misc label Feb 3, 2023
@michalk8 michalk8 self-assigned this Feb 3, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #242 (7c2aa8d) into main (4cebd07) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   85.66%   85.66%   -0.01%     
==========================================
  Files          52       52              
  Lines        5323     5322       -1     
  Branches      813      546     -267     
==========================================
- Hits         4560     4559       -1     
  Misses        643      643              
  Partials      120      120              
Impacted Files Coverage Δ
src/ott/problems/quadratic/quadratic_problem.py 89.32% <ø> (ø)
src/ott/geometry/geometry.py 90.84% <100.00%> (-0.03%) ⬇️

@michalk8 michalk8 merged commit b226202 into ott-jax:main Feb 8, 2023
@michalk8 michalk8 deleted the feature/improve-pre-commits branch February 8, 2023 14:27
michalk8 added a commit that referenced this pull request Jun 27, 2024
* Add `rstcheck` and `doc8`

* Pass `CUDA_VISIBLE_DEVICES` to `tox`

* Add GPU CI runner

* Fix Python version for GPU tests

* Try running without `tox`

* Fix not installing jax[cuda]

* Use different Docker image

* Fix escpape

* Use apt-get

* Do not use `{}`

* Fix not installing `git`

* Use personal Docker image

* Pin `jax[cuda]` version

* Mark grad(sqrtm) as CPU only test

* Fix ICNN hessian test on GPU

* Use `eigvalsh` to check for positive-semidefinite

* Adjust tolerance in a test

* Mark Sinkhorn online as CPU

* Run all tests on GPU

* Skip more tests on GPU

* Update tolerances on k-means test

* Always jit in online Sinkhorn test

* Use simple comparison

* Only run fast GPU tests, try other GPU

* Use previous GPU

* [ci skip] Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants