Fix/debiased entropic map #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 87.92% 80.44% -7.48%
==========================================
Files 52 52
Lines 5309 5314 +5
Branches 544 546 +2
==========================================
- Hits 4668 4275 -393
- Misses 510 888 +378
- Partials 131 151 +20
|
marcocuturi
approved these changes
Jan 27, 2023
| if not self.is_debiased: | ||
| return potential_xy | ||
|
|
||
| ep = EntropicPotentials(self._f_xx, self._g_yy, prob=self._prob) |
There was a problem hiding this comment.
i understand better why you wanted to encode it this way, this is very elegant to reuse the same prob indeed.
michalk8
added a commit
that referenced
this pull request
Jun 27, 2024
* [ci skip] Add `environment.yml` for `binder` * Fix debiasing in `EntropicMap` * Test for collapse in non-debiased case * [ci skip] Add assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.