Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose maximum hit range restriction to circles and sliders #404

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Rian8337
Copy link
Member

@Rian8337 Rian8337 commented Aug 30, 2024

Currently, circles and sliders have a period during which the object cannot be hit even though it has started their lifetime (that is, it is considered an active object within GameScene). The period for both objects are different:

  • For circles, the period starts from when the circle spawns until the approach circle is halfway into the circle. This is problematic as it means that AR imposes an additional hit window that can be stricter than the hit window imposed by OD. For example, if the player plays a beatmap with AR10 (450ms approach time) and OD0 (100ms for great, 200ms for good, 300ms for meh), the most lenient hit offset is 225ms due to the hit window imposed by AR, even though the most lenient hit offset in terms of OD is 300ms.
  • For sliders, the period starts from when the slider spawns until the most lenient hit offset imposed by OD. While this is not as problematic as circles, this means it is impossible to slider break for hitting the slider too early.

To solve these problems, I have changed the period to always be 400ms before the start time of the circle or slider. Do note that this period does not apply to RX as the mod is designed to hit as accurate as possible.

@Rian8337 Rian8337 changed the title Impose restriction to maximum hit range to circles and sliders Impose maximum hit range restriction to circles and sliders Aug 30, 2024
@Rian8337 Rian8337 merged commit f4fd86b into osudroid:master Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant