Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/mint): remove unused parameter from AfterDistributeMintedCoin #2390

Merged
merged 3 commits into from
Aug 13, 2022
Merged

refactor(x/mint): remove unused parameter from AfterDistributeMintedCoin #2390

merged 3 commits into from
Aug 13, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 12, 2022

Closes: #XXX

What is the purpose of the change

AfterDistributeMintedCoin's parameter is unused. Removing it in this PR.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Aug 13, 2022
@p0mvn p0mvn marked this pull request as ready for review August 13, 2022 01:05
@p0mvn p0mvn requested a review from a team August 13, 2022 01:05
@p0mvn p0mvn added the A:backport/v11.x backport patches to v11.x branch label Aug 13, 2022
czarcas7ic
czarcas7ic approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I'm curious if it was always unused or if there was some implementation with mintedCoin that got removed.

@p0mvn
Copy link
Member Author

p0mvn commented Aug 13, 2022

I think it has always been this way because the only module that uses the hook is pool incentives but it can get the needed amount from the module account balance

@p0mvn p0mvn merged commit 2530987 into main Aug 13, 2022
@p0mvn p0mvn deleted the roman/mint-obsolete-param branch August 13, 2022 01:23
mergify bot pushed a commit that referenced this pull request Aug 13, 2022
@p0mvn @mergify
refactor(x/mint): remove unused parameter from AfterDistributeMintedC…
fee85cf 
…oin (#2390)

* refactor(x/mint): remove unused parameter from AfterDistributeMintedCoin

* remove param from mint hook mock

* changelog

(cherry picked from commit 2530987)

# Conflicts:
#	CHANGELOG.md
#	x/mint/types/hooks.go
@mergify mergify bot mentioned this pull request Aug 13, 2022
Merged
p0mvn added a commit that referenced this pull request Aug 13, 2022
@p0mvn
refactor(x/mint): remove unused parameter from AfterDistributeMintedC…
8881008 
…oin (backport #2390)
p0mvn added a commit that referenced this pull request Aug 13, 2022
@mergify @p0mvn
refactor(x/mint): remove unused parameter from AfterDistributeMintedC…
bd41740 
…oin (backport #2390) (#2396)

Co-authored-by: Roman <[email protected]>
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
A:backport/v11.x backport patches to v11.x branch C:docs Improvements or additions to documentation C:x/mint C:x/pool-incentives
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic