add scaling factors to stableswap pool creation #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
reviewed
Jul 31, 2022
ValarDragon
approved these changes
Jul 31, 2022
Co-authored-by: Dev Ojha <[email protected]>
|
@ValarDragon, I've commited your suggestion, is this ready to merge ? |
ValarDragon
reviewed
Aug 4, 2022
Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
reviewed
Aug 5, 2022
|
Yeah I think so! When these branches get onto the main osmosis repo, will be so much faster to get merged :) |
Co-authored-by: Dev Ojha <[email protected]>
|
We can merge once the test passes, sorry for this crazy number of minor back and forths 😓 |
merge main to this branch
Sorry I forgot about the tests, I got them all passed now |
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2166
What is the purpose of the change
add scaling factors to stableswap pool creation
Brief Changelog
MsgCreateStableswapPoolNewStableswapPoolMsgCreateStableswapPoolValidateBasicErrInvalidScalingFactorsTesting and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes