Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/gamm : Fix public/private on GetNextPoolNumber API #1987

Merged
merged 3 commits into from
Jul 7, 2022
Merged

x/gamm : Fix public/private on GetNextPoolNumber API #1987

merged 3 commits into from
Jul 7, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Break off from my simulator work -- Make & Use GetNexttPoolNumber API, make the increment and set API's internal.

This likely will fix some unreported edge cases with queries as well.

Brief Changelog

  • Remove public GetNextPoolNumberAndIncrement method in favor of GetNextPoolNumber

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not documented

@ValarDragon ValarDragon requested a review from a team July 7, 2022 03:51
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jul 7, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 7, 2022
AlpinYukseloglu
AlpinYukseloglu approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mattverse
mattverse approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@ValarDragon ValarDragon merged commit fbc91b7 into main Jul 7, 2022
@ValarDragon ValarDragon deleted the dev/fix_get_next_pool_number_api branch July 7, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

Assignees
No one assigned
Labels
C:docs Improvements or additions to documentation C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @mattverse @AlpinYukseloglu