Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor PR adding some code comments #1101

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

ValarDragon
Copy link
Member

Closes: #XXX

Description

Went through some of the superfluid code with @xBalbinus , left some comments during the discussion. Just PR'ing them


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #1101 (0484ccc) into main (86b4836) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   20.91%   20.94%   +0.02%     
==========================================
  Files         199      199              
  Lines       25426    25429       +3     
==========================================
+ Hits         5319     5326       +7     
+ Misses      19144    19140       -4     
  Partials      963      963              
Impacted Files Coverage Δ
x/superfluid/keeper/stake.go 58.13% <ø> (ø)
x/superfluid/module.go 60.41% <0.00%> (+0.84%) ⬆️
x/lockup/module.go 56.81% <0.00%> (+1.00%) ⬆️
x/incentives/module.go 55.55% <0.00%> (+1.01%) ⬆️
x/superfluid/keeper/msg_server.go 4.54% <0.00%> (+4.54%) ⬆️
x/incentives/keeper/msg_server.go 7.14% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b4836...0484ccc. Read the comment docs.

@ValarDragon ValarDragon merged commit 72dee1f into main Mar 15, 2022
@ValarDragon ValarDragon deleted the dev/superfluid_comments branch March 15, 2022 19:53
mergify bot pushed a commit that referenced this pull request Mar 15, 2022
ValarDragon added a commit that referenced this pull request Mar 15, 2022
(cherry picked from commit 72dee1f)

Co-authored-by: Dev Ojha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants