-
Notifications
You must be signed in to change notification settings - Fork 584
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor: Change Pool API to have separate methods for
JoinPool
and…
… `JoinPoolNoSwap` (#2133) (#2634) * split out no swap joins on pool interface and implement changes for balancer * minor refactor and comment changes for clarity * minor comment changes for review clarity * add tests for new calcs * fix merge-related issues * add changelog entry * add failure case test and make existing tests more robust * clean up validation logic * factor out common denom check and add tests for it * add additional test cases * apply new internal fx where relevant and ensure proper testing * add test case and improve test readability * add tests for edge cases and clean up existing tests * add duplicate pool edge case test * minor comment updates from code review Co-authored-by: Roman <[email protected]> * remove remainingCoins return value from internal no-swap calcs * update mocks * move ensuredenominpool test to amm tests * minor comment updates from code review Co-authored-by: Roman <[email protected]> * pass ctx through no-swap pool joins * add multi asset and edge case tests to calcnoswap Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit 4de8bdf) Co-authored-by: alpo <[email protected]> Co-authored-by: alpo <[email protected]>
- Loading branch information
1 parent
2526d0e
commit f6040be
Showing
11 changed files
with
380 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.