Add new remote authorizer that uses request body and headers #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Marlinc
force-pushed
the
remote-authorizer
branch
8 times, most recently
from
37111c3
to
149f1c4
Compare
Marlinc
force-pushed
the
remote-authorizer
branch
2 times, most recently
from
a984de3
to
92fe3ca
Compare
aeneasr
reviewed
Apr 22, 2020
|
Sorry, forgot to say, this looks really good! Good job on providing docs and everything in one go :) |
Marlinc
force-pushed
the
remote-authorizer
branch
5 times, most recently
from
8a0b3ce
to
25db75d
Compare
aeneasr
reviewed
Apr 23, 2020
Marlinc
force-pushed
the
remote-authorizer
branch
from
25db75d
to
b743d91
Compare
The current remote_json authorizer does not have the ability to send the request body of the request to authorize. This means this cannot be taken into account while checking permissions. Providing the request body as part of the JSON payload won't always work as JSON cannot handle binary data.
Marlinc
force-pushed
the
remote-authorizer
branch
from
b743d91
to
3fee0dc
Compare
|
Thank you, great job! |
|
Hello, |
|
This is documented:
If something is unclear there please propose a change (PR) or open a discussion on the forums/github/slack |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
None that I know
Proposed changes
This pull request implements a new authorizer that sends the original request body as body to the remote endpoint. This allows the remote endpoint to take the body into account in its decision.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments