Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline/authn: add unit test for token_from->cookie for both jwt and oauth2_introspection authenticators (#330) #331

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

ngrigoriev
Copy link
Contributor

@ngrigoriev ngrigoriev commented Jan 7, 2020

pipeline/authn: add unit test for token_from->cookie for both jwt and oauth2_introspection authenticators (#330)

Update the schemas to add missing cookie config element

Signed-off-by: Grigoriev, Nikolai [email protected]

Proposed changes

Add both negative and positive unit tests for both authenticators for "cookie" token origin

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • Separate PR is provided for docs repo

… oauth2_introspection authenticators (ory#330)

Update the schemas to add missing cookie config element

Signed-off-by: Grigoriev, Nikolai <[email protected]>
@aeneasr
Copy link
Member

aeneasr commented Jan 8, 2020

Nice! This looks good - as I mentioned in the docs PR I'd like the schema changes to be updated here as well, otherwise this is good to go!

@ngrigoriev
Copy link
Contributor Author

OK, I have verified the difference - for the affected section there was an empty line that I slipped into the schema in the docs repository. Since I have reverted the change there, this should be good, I think. BTW, I have noticed that the schema files in docs and here are slightly different, looks like the arrays are formatted differently.

@aeneasr
Copy link
Member

aeneasr commented Jan 9, 2020

Ok perfect!

BTW, I have noticed that the schema files in docs and here are slightly different, looks like the arrays are formatted differently.

Yeah we're prettifying the files in ory/docs which can lead to slightly different formatting :)

@aeneasr aeneasr merged commit 7516eed into ory:master Jan 9, 2020
@ngrigoriev ngrigoriev deleted the issue-330 branch January 9, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants