Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pipe to pass body remote authorizer #426

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

Marlinc
Copy link
Contributor

@Marlinc Marlinc commented Apr 30, 2020

Related issue

Proposed changes

The big request test introduced in #416 appears to be flaky and fails every so often. I've made some changes to it and have also changed the piping to use a pipe to pass the original request to the remote authorizer. Instead of creating two in memory buffers.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@aeneasr
Copy link
Member

aeneasr commented Apr 30, 2020

Thank you!

@aeneasr aeneasr merged commit 1a44087 into ory:master Apr 30, 2020
@Marlinc Marlinc deleted the remote-flaky-test branch April 30, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants