Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve CLI build bug with lower case #2121

Merged
merged 1 commit into from
May 10, 2023
Merged

Resolve CLI build bug with lower case #2121

merged 1 commit into from
May 10, 2023

Conversation

harimkang
Copy link
Contributor

Summary

Resolve #2066
Fixed an issue with lowercase template IDs or model names building to the wrong model.

How to test

otx build yolox
otx build YOLOX

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@harimkang harimkang added this to the 1.3.0 milestone May 9, 2023
@github-actions github-actions bot added the CLI Any changes in OTE CLI label May 9, 2023
@harimkang harimkang added FIX defect fix and removed CLI Any changes in OTE CLI labels May 9, 2023
@harimkang harimkang mentioned this pull request May 9, 2023
Closed
@harimkang harimkang marked this pull request as ready for review May 9, 2023 07:51
@harimkang harimkang requested a review from a team as a code owner May 9, 2023 07:51
eunwoosh
eunwoosh approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harimkang harimkang merged commit dc6c671 into openvinotoolkit:develop May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@jaegukhyun jaegukhyun jaegukhyun approved these changes

Assignees
No one assigned
Labels
FIX defect fix
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

otx build can not recognize template when templates are lower case.
3 participants
@harimkang @eunwoosh @jaegukhyun