Initialize flag variable "header" to true in /lib/util/devutil.js

[thinkhy]

Seems we intended to filter header line in the output of "ps comm", it's supposed to initialize flag variable "header" to true.

[sorccu]

You're right. How did you find this though? Even though it's obviously a bug, I don't think it should have caused any issues.

…

On Sun, Jun 11, 2017 at 19:08 thinkhy ***@***.***> wrote: Seems we intended to filter header line in the output of "ps comm", it's supposed to initialize flag variable "header" to true. ------------------------------ You can view, comment on, or merge this pull request online at: #615 Commit Summary - Create devutil.js File Changes - *M* lib/util/devutil.js <https://github.com/openstf/stf/pull/615/files#diff-0> (2) Patch Links: - https://github.com/openstf/stf/pull/615.patch - https://github.com/openstf/stf/pull/615.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#615>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB-_cdvtqFZRWKr5r765fvXY-mL_XGPks5sC7yGgaJpZM4N2WXR> .

[thinkhy]

I found it when reviewed code in the component of "device" in order to add a device plugin for testing.

Actually in the function of "listPidsByComm" in devutil.js, there still exists an incompatibility problem as the shell command "ps comm" is invalid in some devices such as Google Pixel.
Below is the output when I issued "ps com" in Pixel:

 1|sailfish:/ $ ps com
 bad pid 'com'
 1|sailfish:/ $ echo $?
 1

So I suggest to replace "ps comm" with "ps" which is workable for all the Android device.

[sorccu]

Hmm... that's unfortunate. Unfortunately Google doesn't sell the Pixel here so I've never been able to try one myself. I do know that Pixel devices are working in STF, though. Could you perhaps attempt to create a patch?

[thinkhy]

Pixel is not common in China neither, someone sent me this device from US.
OK, I'll create a new patch which only replace "ps comm" with "ps" in listPidsByComm.