Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Incompatibilities with OpenTelemetry LLM semantics pending release #347

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

patcher9
Copy link
Contributor

@patcher9 patcher9 commented Jul 30, 2024

Overview:

This PR introduces changes that makes sure OpenLIT is following the OTel Semantic conventions for GenAI

resolves #342

Changes:

Changes in the SDK

  • Trace attribute gen_ai.request.top_p is made a double
  • Setting default value for Trace attribute gen_ai.request.max_tokens as -1 instead of a string
  • Trace attribute gen_ai.request.temperature is made a double
  • Trace attribute gen_ai.request.presence_penalty is made a double
  • Trace attribute gen_ai.request.frequency_penalty is made a double
  • Trace attribute gen_ai.response.finish_reason' is renamed to 'gen_ai.response.finish_reasons'
  • Trace attribute gen_ai.usage.completion_tokens is renamed to gen_ai.usage.output_tokens
  • Trace attribute gen_ai.usage.prompt_tokens is renamed to gen_ai.usage.input_tokens

Changes in the UI

  • Trace attributes gen_ai.response.finish_reason' is renamed to 'gen_ai.response.finish_reasons'
  • Trace attributes gen_ai.usage.completion_tokens is renamed to gen_ai.usage.output_tokens
  • Trace attributes gen_ai.usage.prompt_tokens is renamed to gen_ai.usage.input_tokens

Visuals (If applicable):

NA

Checklist:

  • PR name follows conventional commit format: [Feat]: ... or [Fix]: ....
  • Added visuals for changes (If applicable)
  • Checked OpenLIT contribution guidelines

@patcher9 patcher9 requested a review from a team as a code owner July 30, 2024 05:26
@patcher9 patcher9 changed the title Follow OTel Semconv with changes from PR [Fix]: Incompatibilities with OpenTelemetry LLM semantics pending release Jul 30, 2024
@patcher9 patcher9 merged commit 1ab1bf3 into main Jul 30, 2024
9 checks passed
@patcher9 patcher9 deleted the otel-conv branch July 30, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incompatibilities with OpenTelemetry LLM semantics pending release
1 participant