This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
EIP 150.1b #2542
Closed
EIP 150.1b #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci:skip]
arkpar
reviewed
Oct 9, 2016
| @@ -73,6 +75,7 @@ impl From<ethjson::spec::EthashParams> for EthashParams { | |||
| difficulty_hardfork_transition: p.difficulty_hardfork_transition.map_or(0x7fffffffffffffff, Into::into), | |||
| difficulty_hardfork_bound_divisor: p.difficulty_hardfork_bound_divisor.map_or(p.difficulty_bound_divisor.into(), Into::into), | |||
| bomb_defuse_transition: p.bomb_defuse_transition.map_or(0x7fffffffffffffff, Into::into), | |||
| bad_gas_compatibility_mode_limit: p.bad_gas_compatibility_mode_limit.map_or(0, Into::into), | |||
There was a problem hiding this comment.
This will break all private chains after upgrade. Maybe leave it disabled by default and just update sample and documentation specs to enable it?
There was a problem hiding this comment.
yeah. the thing is that if we don't default it to 'on', then all private chains will be defaulting to using a broken protocol and run the risk of being internally DoSed.
we can print a warning to ensure they know what went wrong.
|
Looks fine, I think I would get rid of
Looks good otherwise 👍 |
gavofyork
added
A3-inprogress ⏳
gavofyork
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in ethereum/EIPs#150 and implemented in ethereum/pyethereum@6d7e28a .
Still TODO:
suicide_to_new_account_cost.@tomusdrw please review.