feat: add ability to disable SelectMenu #3138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that passing
disabled
as a prop to theSelectMenu
component in a PR that I was working was not having the desired effect. That is because theButton
component in theSelectMenu
component is wrapped by a div that is receiving the additional props.I opted to add an additional
disabled
prop to theSelectMenu
component with a default value offalse
. This additional prop is then used to determine whether or not the button is disabled or not.Deploy Preview
https://deploy-preview-3138--paragon-openedx.netlify.app/components/menu/select-menu/
Merge Checklist
example
app?Post-merge Checklist