Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDUCATOR-5068: 'Upload Membership' button stuck as inactive after uploading and navigating #24288

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Jun 22, 2020

EDUCATOR-5068
@edx/masters-devs-gta

I'm gonna be honest, I don't fully understand this issue. Here's my understanding of what is happening:

  1. Navigate to the teams tab
    • The whole TeamsTabView is created and rendered. At this point, the button works perfectly.
  2. Navigate to a Topic through the Browse Tab, or a Team though the My Teams tab.
    • This will (i think?) get rid of the DOM created by the TeamsTabView? The TeamsTabView will go away somehow. I don't know
  3. Navigate, using the breadcrumb, back to the TeamsTabView
    • The page will re-render? But for some reason the events aren't bound? So now, manually re-bind the events

When we create the ManageView, we bind the events to some part of the DOM, which is good and all, but then we remove that DOM but don't update the events, so the ManageView's events are either unbound or bound to something that doesn't exist anymore, and when we re-render, we're creating new DOM that the view doesn't know about? I think?

Anyway, this PR makes the manage tab rebind events on a re-render, and it seems to fix the issue.

Copy link
Contributor

@jnlapierre jnlapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansenk
Copy link
Contributor Author

jansenk commented Jun 22, 2020

image

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@jansenk
Copy link
Contributor Author

jansenk commented Jun 22, 2020

Just went back to sanity check, and yes, this bug also made the "download CSV" button nonfunctional since it also relied on backbone event handling. we just didn't notice.

@jansenk jansenk merged commit 79a7688 into master Jun 23, 2020
@jansenk jansenk deleted the jkantor/csv-upload-button branch June 23, 2020 17:56
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants