[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam #24214

MatthewPiatetsky · 2020-06-12T19:36:31Z

Otherwise, these learners could start the timer and then be unable to take the exam once they have access to the content
Before:

After:

Course Outline:
Don't think anything needs to be done here
Mobile:
I believe timed exams don't show up here anyway, so this should probably be fine?
Course API:
I don't think the html change would affect this

New Courseware MFE:
Have done a little bit of discovery into this, product will get back to me in terms of whether I should do the additional work for that as part of this ticket or another ticket

MatthewPiatetsky · 2020-06-15T15:41:07Z

common/lib/xmodule/xmodule/seq_module.py

+                self.content_type_gating_enabled = ContentTypeGatingConfig.enabled_for_enrollment(user=user, course_key=self.runtime.course_id)
+                if self.content_type_gating_enabled:
+                    # Get the content type gating locked content fragment to render for this sequence
+                    partition = self.descriptor._get_user_partition(CONTENT_GATING_PARTITION_ID)


are there issues here where the partition could not be defined or the user could not have a group for that partition if a course is using some unusual configuration?

MatthewPiatetsky · 2020-06-15T15:41:40Z

lms/templates/seq_module.html

  % if not exclude_units:
  % if gated_content['gated']:
    <%include file="_gated_content.html" args="prereq_url=gated_content['prereq_url'], prereq_section_name=gated_content['prereq_section_name'], gated_section_name=gated_content['gated_section_name']"/>
+  % elif gated_sequence_fragment:


could a sequence include a timed exam and content outside of the timed exam in the same sequence?

cpennington · 2020-06-15T17:48:49Z

common/lib/xmodule/xmodule/seq_module.py

+            try:
+                user = User.objects.get(id=self.runtime.user_id)
+                # importing here to avoid a circular import
+                from openedx.features.content_type_gating.models import ContentTypeGatingConfig


Rather than having this code live in the sequence module, it might be better to add knowledge to the block-transformer that currently actively gates graded problems. That way you wouldn't be dealing w/ this import cycle, and would instead be just adding knowledge of another kind of feature to be gated.

Even if we're leaving this code here, I think it's worth a note about the future plans with the MFE to explain why this level of pulling in openedx features is warranted. (This breaks the ability to use this sequence block outside of edx-platform, basically. I think we're ok w/ that, but it's worth a note).

@ormsbee, can you double check me on this?

If we wanted to make it less likely to break outside of the platform, we could add another XBlock service that has access to content type gating information.

Agreed on all points.

@cpennington so should I do what you're suggesting? if so could you elaborate?

Leave a note about this breaking compatibility w/ using sequence outside edx-platform, but don't do any further eng work on it.

cpennington · 2020-06-17T15:53:06Z

common/lib/xmodule/xmodule/seq_module.py

+        # This was an issue because audit learners could start a timed exam and then be unable to complete the exam
+        # even if they later upgrade because the timer would have expired.
+        # For this reason we check if content gating is enabled for the user and gate the entire sequence in that case
+        if self.is_time_limited and self.location.block_type == 'sequential':


Why does this have to check its own block_type? Are there other flavors of sequential using this same rendering code that shouldn't be time limited?

i think this was left over from when i was trying to do this in the block transformers, i'll remove it

cpennington · 2020-06-17T15:55:47Z

common/lib/xmodule/xmodule/seq_module.py

+            try:
+                user = User.objects.get(id=self.runtime.user_id)
+                # importing here to avoid a circular import
+                from openedx.features.content_type_gating.models import ContentTypeGatingConfig


Even if we're leaving this code here, I think it's worth a note about the future plans with the MFE to explain why this level of pulling in openedx features is warranted. (This breaks the ability to use this sequence block outside of edx-platform, basically. I think we're ok w/ that, but it's worth a note).

@ormsbee, can you double check me on this?

cpennington · 2020-06-17T15:57:00Z

common/lib/xmodule/xmodule/seq_module.py

+            try:
+                user = User.objects.get(id=self.runtime.user_id)
+                # importing here to avoid a circular import
+                from openedx.features.content_type_gating.models import ContentTypeGatingConfig


If we wanted to make it less likely to break outside of the platform, we could add another XBlock service that has access to content type gating information.

…o access a timed exam Otherwise, these learners could start the timer and then be unable to take the exam once they have access to the content REV-774

edx-status-bot · 2020-06-22T20:45:55Z

Your PR has finished running tests. There were no failures.

edx-pipeline-bot · 2020-06-23T16:47:21Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2020-06-23T17:24:45Z

EdX Release Notice: This PR has been deployed to the production environment.

… flag (#25054) Re-applied bugfix #24214, but behind a waffle flag. The change gates timed exams for audit learners. We would like to limit access to timed exams to verified learners. However, some of the instructors would like to make their content free for all users, including graded content/timed exams (hence the Feature-Based Enrollment "FBE" exemption). As a result, we will be rolling the gated timed exams functionality out behind a waffle flag now, add the FBE exemption when we figure out how, and gradually turn the waffle flag on for everyone.

MatthewPiatetsky force-pushed the REV-774 branch from d68cf02 to 6a8f16c Compare June 15, 2020 15:13

MatthewPiatetsky commented Jun 15, 2020

View reviewed changes

MatthewPiatetsky force-pushed the REV-774 branch from 6a8f16c to ece199c Compare June 15, 2020 15:46

cpennington reviewed Jun 15, 2020

View reviewed changes

MatthewPiatetsky force-pushed the REV-774 branch 3 times, most recently from 28a0d14 to c5b6466 Compare June 17, 2020 12:25

MatthewPiatetsky changed the title ~~[WIP] [REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam~~ [REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam Jun 17, 2020

cpennington reviewed Jun 17, 2020

View reviewed changes

Show content type gating upsell when a limited access learner tries t…

78317ca

…o access a timed exam Otherwise, these learners could start the timer and then be unable to take the exam once they have access to the content REV-774

MatthewPiatetsky force-pushed the REV-774 branch from c5b6466 to 78317ca Compare June 22, 2020 20:19

cpennington approved these changes Jun 23, 2020

View reviewed changes

MatthewPiatetsky merged commit b3c2d37 into master Jun 23, 2020

MatthewPiatetsky deleted the REV-774 branch June 23, 2020 15:48

MatthewPiatetsky mentioned this pull request Jul 15, 2020

Revert "[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam" #24505

Merged

jhan217 mentioned this pull request Sep 28, 2020

[REV-1508] Add functionality to limit timed exam access behind waffle flag #25054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam #24214

[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam #24214

MatthewPiatetsky commented Jun 12, 2020 •

edited

Loading

MatthewPiatetsky Jun 15, 2020

MatthewPiatetsky Jun 15, 2020

cpennington Jun 15, 2020

cpennington Jun 17, 2020

cpennington Jun 17, 2020

ormsbee Jun 17, 2020

MatthewPiatetsky Jun 18, 2020

cpennington Jun 22, 2020

cpennington Jun 17, 2020

MatthewPiatetsky Jun 17, 2020

cpennington Jun 17, 2020

cpennington Jun 17, 2020

edx-status-bot commented Jun 22, 2020

edx-pipeline-bot commented Jun 23, 2020

edx-pipeline-bot commented Jun 23, 2020

[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam #24214

[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam #24214

Conversation

MatthewPiatetsky commented Jun 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edx-status-bot commented Jun 22, 2020

edx-pipeline-bot commented Jun 23, 2020

edx-pipeline-bot commented Jun 23, 2020

MatthewPiatetsky commented Jun 12, 2020 •

edited

Loading