Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bulk unenroll mgmt cmd #23544

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Refactor bulk unenroll mgmt cmd #23544

merged 1 commit into from
Apr 3, 2020

Conversation

uzairr
Copy link
Contributor

@uzairr uzairr commented Mar 31, 2020

Description

PROD-1347

Bulk unenroll command is not supporting unenrolling all the learners from multiple courses.This PR will enhance this mgmt cmd so that it can support un-enrollment of learners from multiple courses.

@uzairr uzairr requested a review from a team March 31, 2020 11:19
Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reading course ids from a CSV, can't we simply pass a list of course ids directly to the management command?

@uzairr
Copy link
Contributor Author

uzairr commented Mar 31, 2020

@waheedahmed yes we can do that but let say if we have 50 courses in which un-enrollment needs to be done then there is a chance to hit the command-line argument limit.
https://stackoverflow.com/questions/19354870/bash-command-line-and-input-limit

@uzairr uzairr force-pushed the refactor_bulk_unenroll branch 2 times, most recently from 8629628 to cf919dd Compare April 2, 2020 10:47
@uzairr uzairr force-pushed the refactor_bulk_unenroll branch 2 times, most recently from 5a8fd55 to a67c2d9 Compare April 3, 2020 10:28
Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments otherwise 👍

Bulk unenroll command is not supporting unenrolling all the learners
from multiple courses.This PR will enhance this mgmt cmd so that
it can support un-enrollment of learners from multiple courses.

PROD-1347
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@uzairr uzairr merged commit 9fbae19 into master Apr 3, 2020
@uzairr uzairr deleted the refactor_bulk_unenroll branch April 3, 2020 13:53
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants