-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bulk unenroll mgmt cmd #23544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of reading course ids from a CSV, can't we simply pass a list of course ids directly to the management command?
@waheedahmed yes we can do that but let say if we have 50 courses in which un-enrollment needs to be done then there is a chance to hit the command-line argument limit. |
8629628
to
cf919dd
Compare
5a8fd55
to
a67c2d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments otherwise 👍
common/djangoapps/student/management/tests/test_bulk_unenroll.py
Outdated
Show resolved
Hide resolved
Bulk unenroll command is not supporting unenrolling all the learners from multiple courses.This PR will enhance this mgmt cmd so that it can support un-enrollment of learners from multiple courses. PROD-1347
a67c2d9
to
4563b87
Compare
Your PR has finished running tests. There were no failures. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Description
PROD-1347
Bulk unenroll command is not supporting unenrolling all the learners from multiple courses.This PR will enhance this mgmt cmd so that it can support un-enrollment of learners from multiple courses.