Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE-2176 Fix elem not selected if id contains special chars #23039

Merged
merged 5 commits into from
Jun 19, 2020

Commits on May 3, 2020

  1. Fix elem not selected if id contains special chars

    If the id of a `.formulaequationinput input` element contains a special
    character, then the selector for $preview was silently failing to match
    the element, because no escaping was happening.
    
    This fixes the issue by escaping the id before passing to the jQuery
    selector function. CSS.escape is the ideal method, but this isn't
    present in IE or Edge, so we use a fallback borrowed from the new
    jQuery.escapeSelector method.
    Samuel Walladge committed May 3, 2020
    Configuration menu
    Copy the full SHA
    9c4b458 View commit details
    Browse the repository at this point in the history
  2. Fix issues with xss linters

    Improve accuracy of javascript-escape linter: Previously this would
    match on FOOescape() and FOO.escape calls, but neither are the global
    escape function we are worried about.
    
    The regex probably isn't 100% accurate; there may be still false
    positives (javascript allows a large range of characters in identifiers,
    some of which may not be covered by [\w.$]). The main thing is to avoid
    false negatives here though - this will definitely catch any use of
    `escape()` or `window.escape()`.
    
    Also remove javascript-interpolate lint - this was deemed unecessary.
    StringUtils.interpolate is not in fact safe (it does no html escaping),
    so the results of this lint are misleading.
    Samuel Walladge committed May 3, 2020
    Configuration menu
    Copy the full SHA
    71fcf6e View commit details
    Browse the repository at this point in the history
  3. Fix capa's static_url on devstack in new runtime

    bradenmacdonald authored and Samuel Walladge committed May 3, 2020
    Configuration menu
    Copy the full SHA
    fe06bc8 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. restructure code to pass lints

    Samuel Walladge committed May 4, 2020
    Configuration menu
    Copy the full SHA
    18c7d72 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Merge remote-tracking branch 'origin/master' into samuel/fix-unescape…

    …d-selector
    Samuel Walladge committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    43f0cd7 View commit details
    Browse the repository at this point in the history