Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak random_agent #406

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Unbreak random_agent #406

merged 1 commit into from
Dec 7, 2016

Conversation

avital
Copy link
Contributor

@avital avital commented Nov 22, 2016

The semantics of env.reset() have changed. It's no longer possible
to reset an environment until it's done.

Notably, this commit changes the behavior of random_agent. It used
to have a limit on number of actions per episode. If we wanted
that now, we'd have to close the environment and recreate it
on each episode, which may be slow.

The semantics of `env.reset()` have changed. It's no longer possible
to reset an environment until it's done.

Notably, this commit changes the behavior of random_agent. It used
to have a limit on number of actions per episode. If we wanted
that now, we'd have to close the environment and recreate it
on each episode, which may be slow.
@tlbtlbtlb
Copy link
Contributor

tlbtlbtlb commented Nov 22, 2016

LGTM

@avital
Copy link
Contributor Author

avital commented Nov 22, 2016

Tests are failing, almost certainly not due to this change. Are there flaky tests?

FAIL: gym.envs.tests.test_envs_semantics.test_env_semantics:138
EnvSpec(Blackjack-v0)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/gym/gym/envs/tests/test_envs_semantics.py", line 82, in test_env_semantics
    assert rollout_dict[spec.id]['rewards'] == rewards_now, 'Rewards not equal for {}'.format(spec.id)
AssertionError: Rewards not equal for Blackjack-v0

@gdb gdb merged commit 8676fa8 into openai:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants