-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker - Minor fix for pull requests #286
Conversation
ppaquette
commented
Aug 11, 2016
- MUJOCO_KEY_BUNDLE is an empty string in pull requests, rather than being unset.
- Split py27 and py34 to avoid hitting the 50 mins timeout, and for easier debugging.
- COPY takes a trailing slash as per documentation
Thanks! Really need to figure out how to make these builds faster... I was hoping pulling a built image would do it, but doesn't seem to. Maybe next step is to try some explicit export-to-a-cachedir scheme? |
The hashes from the build don't match the one you have in cache. ubuntu:14.04 is periodically updated, and the cached version is 3 months old, vs the current one is 2 weeks old. You should probably create a gym:base image, and change the Dockerfile "FROM" to use that instead. in cache:
built:
|
Ah, good find! Yep, sounds like a plan. |
Looks like your 3.4 failed. Will merge after fixup! |
Looks like there's a deeper issue with performance (build caching like this stopped being supported in 1.10): moby/moby#20316 (comment). I do have an easy trick still... namely, having a much more built-up "base" image. Will see if I can get that running easily. |
3.4 is caused by Segmentation fault. Happens ~ 30% of the time. Not sure what env is causing it. |