Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: use ErrorContains and EqualError #35483

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[chore]: use ErrorContains and EqualError #35483

merged 1 commit into from
Sep 30, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint doesn't support it yet.
This replaces Contains(t, err.Error() by ErrorContains(t, err and Equal(t, err.Error() by EqualError(t, err
As they both check for nil error it becomes useless to check it yourself without having defined a custom message

@mmorel-35 mmorel-35 marked this pull request as ready for review September 28, 2024 12:16
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Sep 30, 2024
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 30, 2024
@djaglowski djaglowski merged commit 7503861 into open-telemetry:main Sep 30, 2024
172 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 30, 2024
@mmorel-35 mmorel-35 deleted the testify/error-contains branch September 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@songy23 songy23 songy23 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

Assignees

@atoulme atoulme

Labels
ci-cd CI, CD, testing, build issues connector/count connector/sum exporter/clickhouse exporter/kafka exporter/loki Loki Exporter exporter/otelarrow exporter/signalfx exporter/splunkhec extension/oauth2clientauth extension/observer internal/aws internal/core internal/docker internal/kafka pkg/ottl pkg/sampling pkg/stanza processor/geoip ready to merge Code review completed; ready to merge by maintainers receiver/activedirectoryds receiver/apachespark receiver/awsxray receiver/bigip receiver/cloudflare receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/flinkmetrics receiver/fluentforward receiver/github receiver/hostmetrics receiver/jmx JMX Receiver receiver/kafka receiver/kafkametrics receiver/mongodb receiver/mongodbatlas receiver/otelarrow receiver/podman receiver/prometheus Prometheus receiver receiver/rabbitmq receiver/receivercreator receiver/redis Redis related issues receiver/riak receiver/saphana receiver/snmp receiver/snowflake Snowflake receiver receiver/solace receiver/statsd statsd related issues receiver/webhookevent
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorel-35 @atoulme @songy23 @crobert-1 @djaglowski