[pkg/ottl]: add SliceToMap function #35412
Draft
+559
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
atoulme,
BinaryFissionGames and
tigrannajaryan
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
commented
Oct 1, 2024
| @@ -84,12 +94,29 @@ func Test_e2e_editors(t *testing.T) { | |||
| m.PutStr("test.foo.flags", "pass") | |||
| m.PutStr("test.foo.slice.0", "val") | |||
| m.PutStr("test.foo.nested.test", "pass") | |||
|
|
|||
There was a problem hiding this comment.
@evan-bradley @TylerHelmuth - This is not related to the function implemented in this PR, but after adding a slice of nested objects to the test attributes I found that the flatten function seems to not flatten the attributes of nested objects within a slice, but rather leaves the objects within the slice unchanged - is this intended or is this a bug in that function?
Also, when setting the depth to 0 (as in the test case below), slices at the top level of the input of the flatten function will still be flattened.
Please let me know if this behavior is intended or if this may be a bug - If it's the latter, I can create an issue for that and work on a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a function that converts slices to maps, as described in the linked issue. Currently still WIP, but creating a draft PR already to show how this could be implemented and used
Link to tracking Issue: #35256
Testing: Added unit and end to end tests
Documentation: Added description for the new function in the readme file