[pkg/stanza] Windows input operator should resubscribe when remote host restarts

[kuiperda]

Description:

While collecting Windows Event Logs from a remote host, if that host restarts or shuts off, the collector begins logging errors and stops collecting WE logs, even after the remote host is back up. Restarting the collector fixes this.

To fix this without restarting the collector, the stanza input operator needs to resubscribe if the remote host restarts.

Error log:

"Failed to read events from subscription","error":"The handle is invalid."

Link to tracking Issue:

Testing:

Manually tested with a build of the collector, and confirmed logs continue being collected after the remote host restarts.

Documentation:

N/A, this change is expected behavior

[pjanotti]

/label os:windows

[pjanotti]

/label Run Windows

Not sure if this works...

[VihasMakwana]

We check for a remote subscription here

opentelemetry-collector-contrib/pkg/stanza/operator/input/windows/input.go

Lines 128 to 131 in 9139ce1

	subscription := NewLocalSubscription()
	if i.isRemote() {
	subscription = NewRemoteSubscription(i.remote.Server)
	}

I think we should also do same while resubscribing. What do you say?

[VihasMakwana]

Apart from my last comment, LGTM

[pjanotti]

When a remote subscription is created its handle is invalid (0). The subscription needs to be opened before using it to read remote events.

[VihasMakwana]

LGTM!

[kuiperda]

@atoulme this can be merged