Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing the instana exporter code #34994

Closed
atoulme opened this issue Sep 4, 2024 · 2 comments · Fixed by #35367
Closed

Consider removing the instana exporter code #34994

atoulme opened this issue Sep 4, 2024 · 2 comments · Fixed by #35367
Labels
exporter/instana

Comments

@atoulme
Copy link
Contributor

atoulme commented Sep 4, 2024

Component(s)

exporter/instana

Describe the issue you're reporting

Given that the instana exporter was deprecated as of 6 months, it is now time to consider removing the code: #31765

Given that the code was not explicitly deprecated, follow this approach:

  • Mark the code and module as deprecated
  • Wait for one release to publish the deprecation
  • Delete the code.
@atoulme atoulme added the needs triage New item requiring triage label Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@Frapschen Frapschen mentioned this issue Sep 6, 2024
Merged
@Frapschen Frapschen removed the needs triage New item requiring triage label Sep 6, 2024
jpkrohling pushed a commit that referenced this issue Sep 9, 2024
@Frapschen
Marking instanaexporter module as deprecated (#35052)
f81fd7a 
**Description:** <Describe what has changed.>
Follow #18503, Marking instanaexporter module as deprecated.

**Link to tracking Issue:** #34994

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Murphy Chen <[email protected]>
@github-actions github-actions bot mentioned this issue Sep 10, 2024
Open
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@Frapschen @f7o
Marking instanaexporter module as deprecated (open-telemetry#35052)
60b7480 
**Description:** <Describe what has changed.>
Follow open-telemetry#18503, Marking instanaexporter module as deprecated.

**Link to tracking Issue:** open-telemetry#34994

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Murphy Chen <[email protected]>
@atoulme
Copy link
Contributor Author

atoulme commented Sep 13, 2024

Thanks @Frapschen . Now is a good time to delete the code in a second PR.

This was referenced Sep 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/instana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exporter/instana: remove deprecated exporter codeboten/opentelemetry-collector-contrib
2 participants
@atoulme @Frapschen