Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_alg_info.py on Windows platform #1821

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

qnfm
Copy link
Contributor

@qnfm qnfm commented Jun 14, 2024

Fix test_alg_info.py on Windows which cause the ninja run_tests failure.

Since gerp is not available on Windows, making use of powershell is a good alternative way to replace grep.

tests/test_alg_info.py Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for bringing in Windows knowhow!

Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution!

@SWilson4 SWilson4 merged commit c8a2beb into open-quantum-safe:main Jun 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants