Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1769

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Update README.md #1769

merged 1 commit into from
Apr 25, 2024

Conversation

vsoftco
Copy link
Member

@vsoftco vsoftco commented Apr 25, 2024

fixed typo in link

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

fixed typo in link

Signed-off-by: Vlad Gheorghiu <[email protected]>
@vsoftco vsoftco requested a review from dstebila as a code owner April 25, 2024 14:49
@praveksharma praveksharma self-requested a review April 25, 2024 15:31
@praveksharma praveksharma merged commit 9c8db18 into main Apr 25, 2024
81 checks passed
@baentsch
Copy link
Member

Gentlemen, this reverts #1715: Why? This triggers again a failure in doc-gen with a recent doxygen (that we apparently do not have in CI: Created open-quantum-safe/ci-containers#75 to track).

@Martyrshot
Copy link
Member

Martyrshot commented Apr 27, 2024

100% my fault @baentsch . Apologies. The edit made sense to me and I defaulted to "the ci will catch any doc generation errors". I can work on reverting this if you'd like.

@baentsch
Copy link
Member

baentsch commented Apr 27, 2024

NP--And at least 70% my fault for not ensuring CI can catch this. Adding: Please sync with @praveksharma as he's looking into the CI improvement...

@vsoftco
Copy link
Member Author

vsoftco commented May 1, 2024

Gentlemen, this reverts #1715: Why? This triggers again a failure in doc-gen with a recent doxygen (that we apparently do not have in CI: Created open-quantum-safe/ci-containers#75 to track).

@baentsch No idea it'll trigger an error, thanks for catching it!

SWilson4 pushed a commit that referenced this pull request Jun 5, 2024
fixed typo in link

Signed-off-by: Vlad Gheorghiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants