Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riscv zephyr support #1641

Merged
merged 11 commits into from
Jan 14, 2024
Merged

Conversation

trigpolynom
Copy link
Contributor

@trigpolynom trigpolynom commented Dec 23, 2023

Adds riscv32 support to the zephyr-rtos module.

This addresses Issue #1416.

@trigpolynom trigpolynom changed the title Riscv support Riscv zephyr support Dec 23, 2023
@trigpolynom trigpolynom marked this pull request as ready for review December 24, 2023 01:12
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional platform support. Please also document it in "PLATFORMS.md". I'd suggest adding it as Tier 2, unless someone disagrees.

@trigpolynom
Copy link
Contributor Author

thanks for the prompt review @baentsch, added the else clauses and added to PLATFORMS.md

baentsch
baentsch previously approved these changes Dec 24, 2023
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @trigpolynom ! Now LGTM. 2nd review, please @SWilson4 @dstebila .

@SWilson4
Copy link
Member

SWilson4 commented Jan 2, 2024

Thanks for the additional platform support. Please also document it in "PLATFORMS.md". I'd suggest adding it as Tier 2, unless someone disagrees.

This is probably out of scope for this PR, but glancing at PLATFORMS.md, it looks like the only entry for Zephyr is the (proposed) one for RISCV. Do you know if this is intentional @baentsch, or should it be updated?

@baentsch
Copy link
Member

baentsch commented Jan 2, 2024

Thanks for the additional platform support. Please also document it in "PLATFORMS.md". I'd suggest adding it as Tier 2, unless someone disagrees.

This is probably out of scope for this PR, but glancing at PLATFORMS.md, it looks like the only entry for Zephyr is the (proposed) one for RISCV. Do you know if this is intentional @baentsch, or should it be updated?

How would you suggest updating it? Zephyr is the only runtime where we have tests for that HW, so listing something different (Linux?) or generic might set wrong expectations.

@SWilson4
Copy link
Member

SWilson4 commented Jan 2, 2024

Thanks for the additional platform support. Please also document it in "PLATFORMS.md". I'd suggest adding it as Tier 2, unless someone disagrees.

This is probably out of scope for this PR, but glancing at PLATFORMS.md, it looks like the only entry for Zephyr is the (proposed) one for RISCV. Do you know if this is intentional @baentsch, or should it be updated?

How would you suggest updating it? Zephyr is the only runtime where we have tests for that HW, so listing something different (Linux?) or generic might set wrong expectations.

Ah, I meant documenting support for Zephyr on other architectures, not other OSes for RISCV. It looks to me like we have CI for Zephyr on x86 and support building Zephyr on Arm.

CMakeLists.txt Outdated Show resolved Hide resolved
@Frauschi
Copy link
Contributor

Frauschi commented Jan 2, 2024

Hi there,

nice to see new platforms added to the Zephyr port so quickly 😄 I left a single comment regarding the general CMakeLists.txt change, otherwise, this looks very good.

Ah, I meant documenting support for Zephyr on other architectures, not other OSes for RISCV. It looks to me like we have CI for Zephyr on x86 and support building Zephyr on Arm.

I think this should have happened within my initial Zephyr port PR. I can add this next week once I‘m back in the office.

@baentsch
Copy link
Member

baentsch commented Jan 2, 2024

Ah, I meant documenting support for Zephyr on other architectures, not other OSes for RISCV. It looks to me like we have CI for Zephyr on x86 and support building Zephyr on Arm.

Good point(s). @trigpolynom : (How) would you want to add these HW platforms to "PLATFORMS.md"?

@trigpolynom
Copy link
Contributor Author

trigpolynom commented Jan 4, 2024

Good point(s). @trigpolynom : (How) would you want to add these HW platforms to "PLATFORMS.md"?

I'm not partial to any particular representation! I'd best defer to you and your colleagues' preferences!

PLATFORMS.md Outdated Show resolved Hide resolved
@baentsch baentsch dismissed their stale review January 8, 2024 17:07

Waiting for platform update

@Frauschi
Copy link
Contributor

@trigpolynom as #1658 with my fixes is merged now, you can rebase to finalize this PR. 😄

@trigpolynom
Copy link
Contributor Author

@Frauschi thank you! Rebased and merged and should be good to go @baentsch

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update(s) @trigpolynom @Frauschi !

@baentsch baentsch merged commit bb23b3f into open-quantum-safe:main Jan 14, 2024
34 checks passed
@Frauschi Frauschi mentioned this pull request Jan 15, 2024
dstebila pushed a commit that referenced this pull request Jan 16, 2024
* Minor fixes for the `CMakeLists.txt` file in the `zephyr` directory
propably happened during rebasing of #1641.
* Minor improvements to the Zephyr specific CMake workarounds
* RiscV distinct board references have been removed to
support all RiscV boards Zephyr supports.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants