Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement iter protocol for Loader #150

Merged
merged 2 commits into from
May 6, 2021
Merged

Implement iter protocol for Loader #150

merged 2 commits into from
May 6, 2021

Conversation

innerlee
Copy link
Contributor

@innerlee innerlee commented May 3, 2021

Otherwise, the loader is not compatible with for loop iteration.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #150 (ed2832b) into main (0e70f99) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head ed2832b differs from pull request most recent head 2a885d9. Consider uploading reports for the commit 2a885d9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   80.23%   80.26%   +0.02%     
==========================================
  Files         107      107              
  Lines        6518     6527       +9     
  Branches      948      949       +1     
==========================================
+ Hits         5230     5239       +9     
  Misses       1061     1061              
  Partials      227      227              
Flag Coverage Δ
unittests 80.26% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/datasets/utils/loader.py 98.18% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e70f99...2a885d9. Read the comment docs.

@innerlee innerlee removed the need test label May 6, 2021
@cuhk-hbsun cuhk-hbsun merged commit 5054a3f into main May 6, 2021
@cuhk-hbsun cuhk-hbsun deleted the zz/iter branch May 6, 2021 09:51
quincylin1 pushed a commit to quincylin1/mmocr-1 that referenced this pull request May 17, 2021
* Implement iter protocal for Loader

Signed-off-by: lizz <[email protected]>

* Test iter protocal

Signed-off-by: lizz <[email protected]>
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Implement iter protocal for Loader

Signed-off-by: lizz <[email protected]>

* Test iter protocal

Signed-off-by: lizz <[email protected]>
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Implement iter protocal for Loader

Signed-off-by: lizz <[email protected]>

* Test iter protocal

Signed-off-by: lizz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants