[Feture] kie visualizer #1267
Merged
[Feture] kie visualizer #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harold-lkk
force-pushed
the
lkk/kie_visualizer
branch
3 times, most recently
from
78475f6
to
b14c408
Compare
Harold-lkk
force-pushed
the
lkk/kie_visualizer
branch
from
b14c408
to
faa137b
Compare
Harold-lkk
force-pushed
the
lkk/kie_visualizer
branch
2 times, most recently
from
10f9a64
to
e46c95b
Compare
gaotongxiao
reviewed
Aug 28, 2022
Comment on lines
+78
to
+80
| if colors is not None and isinstance(colors, Sequence): | ||
| size = math.ceil(len(labels) / len(colors)) | ||
| colors = (colors * size)[:len(labels)] |
There was a problem hiding this comment.
Inconsistent with docstr. Docstr suggesting:
The colors of labels.
``colors`` can be a list of values or just a single
value. If ``colors`` is a single value, all the labels will have
the same color. Otherwise, colors will be assigned to
labels through round robin. Refer to `matplotlib.colors` for the
full list of formats that are accepted. Defaults to 'k'.
Besides, colors doesn't take effect in this method.
| to 10. | ||
| auto_font_size (bool): Whether to automatically adjust font size. | ||
| Defaults to False. | ||
| """ |
| colors: Union[str, Sequence[str]] = 'g', | ||
| filling: bool = False, | ||
| line_width: Union[int, float] = 0.5, | ||
| alpha: float = 0.5) -> np.ndarray: |
| self.is_openset = is_openset | ||
|
|
||
| @staticmethod | ||
| def _draw_labels(visualizer: Visualizer, |
There was a problem hiding this comment.
Delete, if inherited from BaseLocalVisualizer
| pred_img_data = None | ||
|
|
||
| if draw_gt: | ||
| gt_bboxes = data_sample.gt_instances.bboxes |
There was a problem hiding this comment.
Suggested change
| gt_bboxes = data_sample.gt_instances.bboxes | |
| gt_bboxes = data_sample.gt_instances.get('bboxes', None) |
Do the change you have taken my previous suggestions in _draw_instances, same for line 353
Comment on lines
382
to
383
| x_datas: Union[np.ndarray, torch.Tensor], | ||
| y_datas: Union[np.ndarray, torch.Tensor], |
There was a problem hiding this comment.
Suggested change
| x_datas: Union[np.ndarray, torch.Tensor], | |
| y_datas: Union[np.ndarray, torch.Tensor], | |
| x_data: Union[np.ndarray, torch.Tensor], | |
| y_data: Union[np.ndarray, torch.Tensor], |
| arrow_shapes (str or list[str]]): The shapes of arrow heads. | ||
| ``arrow_shapes`` can have the same length with lines or just | ||
| single value. If ``arrow_shapes`` is single value, all the | ||
| lines will have the same shape. Defaults to 'full'. |
| if len(x_datas.shape) == 1: | ||
| x_datas = x_datas[None] | ||
| y_datas = y_datas[None] | ||
| number_arrow = x_datas.shape[0] |
There was a problem hiding this comment.
Suggested change
| number_arrow = x_datas.shape[0] | |
| num_arrows = x_datas.shape[0] |
Comment on lines
+31
to
+39
| edge_labels (np.ndarray, torch.Tensor): The edge labels to draw. | ||
| The shape of edge_labels should be (N, N), where N is the | ||
| number of texts. | ||
| texts (Sequence[str]): The texts to draw. The length of texts | ||
| should be the same as the number of bboxes. | ||
| class_names (dict): The class names for bbox labels. | ||
| is_openset (bool): Whether the dataset is openset. Default: False. |
There was a problem hiding this comment.
del, also don't forget to sync the docstring after updating the counterpart in KIEVisualizer
gaotongxiao
force-pushed
the
lkk/kie_visualizer
branch
from
e46c95b
to
d646899
Compare
gaotongxiao
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.