Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable cursor blinking #165

Closed
olivierkes opened this issue Oct 18, 2017 · 8 comments
Closed

Feature request: disable cursor blinking #165

olivierkes opened this issue Oct 18, 2017 · 8 comments
Milestone

Comments

@olivierkes
Copy link
Owner

Disable cursor blinking in order to reduce distractions. See #163.

That can be easily done with QApplication::cursorFlashTime and QStyleHints::cursorFlashTime.

@olivierkes
Copy link
Owner Author

You can now disable cursor blinking in settings:

image

It doesn't work on my system, but I've been calling qApp.setCursorFlashTime(0) just like many other coders do. It might be my qt version that is buggy (same as for text alignment/justify).

Please tell me if it works for you (it's on branch future)

@olivierkes olivierkes modified the milestones: Future, 0.6.0 Oct 19, 2017
@gedakc
Copy link
Collaborator

gedakc commented Oct 19, 2017

When I enable the Disable blinking checkbox, the cursor stops blinking.
However when I disable the Disable blinking checkbox, the cursor fails to start blinking again.

In the console I see the following messages:

$ manuskript &
Debug: Web rendering engine used: QWebView
Running manuskript version 0.4.0.
Note: No translator found or loaded for locale en_CA.
Loading: /home/gedakc/tmp/deleteme-6.msk
Detected file format version: 1. Zip: True.
Project /home/gedakc/tmp/deleteme-6.msk loaded.
Traceback (most recent call last):
  File "/home/gedakc/workspace/manuskript/bin/../manuskript/settingsWindow.py", line 488, in setApplicationCursorBlinking
    qApp.setCursorFlashTime(mw._defaultCursorFlashTime)
NameError: name 'mw' is not defined

@olivierkes
Copy link
Owner Author

Thanks, fixed. Though I thought I tested that, strange... Anyway, I'm going to check if I can install a newer version of Qt.

@gedakc
Copy link
Collaborator

gedakc commented Oct 19, 2017

Using the latest feature/future branch with last commit d78b819 I confirm that enabling and disabling of the blinking cursor works.

Regarding different versions of Qt, I find it useful to have Virtual Machines with different distro versions each containing the default Qt version for that distro version.

@vithiri
Copy link

vithiri commented Oct 19, 2017

Confirmed as above here as well. 😃

@olivierkes
Copy link
Owner Author

Updated my Qt version and was able to confirm as well. Thanks for testing !

Regarding different versions of Qt, I find it useful to have Virtual Machines with different distro versions each containing the default Qt version for that distro version.

Good idea. But right now I only have a cheap chromebook running ubuntu with crouton, and less than 1gb disk free, so this is unfortunately not an option. :)

@gedakc
Copy link
Collaborator

gedakc commented Oct 20, 2017

Regarding no room for virtual machines: No worries. It was just a suggestion, and yes you are correct that it would required significantly more resources than "1GB disk free".

Kudos to you developing on an inexpensive chromebook. It speaks well for Manuskript running on low spec computers if Manuksript can also be developed on the same. :-)

@gedakc gedakc modified the milestones: 0.6.0, 0.5.0 Mar 3, 2018
@gedakc
Copy link
Collaborator

gedakc commented Mar 3, 2018

Changing milestone to 0.5.0 because the enhancement was committed on Oct. 19, 2017 and hence included in the 0.5.0 release on Oct. 31, 2017. This milestone correction is being done to ensure that the github_changelog_generator functions properly to automatically create CHANGELOG.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants